This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Have ThreadPantheonNodeRunner support plugin tests. #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do plugin lifecycle in ThreadPantheonNodeRunner * Sniff out rendezvous directory for test during register call, it changes.
mbaxter
approved these changes
May 21, 2019
| @@ -62,8 +65,7 @@ private void onBlockAnnounce(final String json) { | |||
| final int blockCount = blockCounter.incrementAndGet(); | |||
| LOG.info("I got a new block! (I've seen {}) - {}", blockCount, json); | |||
| try { | |||
| final File callbackFile = | |||
| new File(System.getProperty("pantheon.plugins.dir", "plugins"), "newBlock." + blockCount); | |||
| final File callbackFile = new File(callbackDir, "newBlock." + blockCount); | |||
There was a problem hiding this comment.
Should each plugin get its own directory??
There was a problem hiding this comment.
I'll do that when we add another plugin.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)