This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2547] Modified JSON-RPC subscription processing to avoid blockin… #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Jun 2, 2019
...ethereum/jsonrpc/websocket/subscription/blockheaders/NewBlockHeadersSubscriptionService.java
Outdated
Show resolved
Hide resolved
...sys/pantheon/ethereum/jsonrpc/websocket/subscription/syncing/SyncingSubscriptionService.java
Outdated
Show resolved
Hide resolved
...reum/jsonrpc/websocket/subscription/blockheaders/NewBlockHeadersSubscriptionServiceTest.java
Outdated
Show resolved
Hide resolved
ajsutton
reviewed
Jun 6, 2019
...ethereum/jsonrpc/websocket/subscription/blockheaders/NewBlockHeadersSubscriptionService.java
Outdated
Show resolved
Hide resolved
...ethereum/jsonrpc/websocket/subscription/blockheaders/NewBlockHeadersSubscriptionService.java
Outdated
Show resolved
Hide resolved
...pantheon/ethereum/jsonrpc/websocket/subscription/syncing/SyncingSubscriptionServiceTest.java
Outdated
Show resolved
Hide resolved
ajsutton
approved these changes
Jun 6, 2019
.../java/tech/pegasys/pantheon/ethereum/jsonrpc/websocket/subscription/SubscriptionManager.java
Outdated
Show resolved
Hide resolved
…jsonrpc/websocket/subscription/SubscriptionManager.java Error logging improvement. Co-Authored-By: Adrian Sutton <[email protected]>
iikirilov
pushed a commit
to Puneetha17/pantheon
that referenced
this pull request
Jun 8, 2019
PegaSysEng#1519) * [PAN-2547] Modified JSON-RPC subscription processing to avoid blocking important threads. * [PAN-2547] Changed executor to Vertx managed. * [PAN-2547] Refactored vertx thread handling to super + refactored tests. * Update ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/websocket/subscription/SubscriptionManager.java Error logging improvement. Co-Authored-By: Adrian Sutton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g important threads.
PR description
Modified how some JSON-RPC subscriptions are being process to avoid blocking important threads (synchronizer etc.)
Fixed Issue(s)
#PAN-2547