This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
When retrieving transactions by hash, check the pending transactions first #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…first. Previously it was possible for a transaction to be "missed" by this call if it was added to a block between when we checked the blockchain and when we checked the pending transaction pool.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Previously it was possible for a transaction to be "missed" by calls to
eth_getTransactionByHashif the transaction was added to a block between when we checked the blockchain and when we checked the pending transaction pool.Since transactions are added to the blockchain before being removed from the pending transactions, we are guaranteed to find the transaction if we check the pending transaction pool first because if it's not there it would already be in the blockchain and thus be returned when we request it.
This also has the advantage of performing the in-memory lookup first and only then falling back to the disk-based lookup if required.