This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
[PIE-1612] [PIE-1613] liveness and readiness probe stub endpoints #1553
Merged
AbdelStark
merged 7 commits into
PegaSysEng:master
from
AbdelStark:feature/kubernetes-liveness-readiness
Jun 13, 2019
Merged
[PIE-1612] [PIE-1613] liveness and readiness probe stub endpoints #1553
AbdelStark
merged 7 commits into
PegaSysEng:master
from
AbdelStark:feature/kubernetes-liveness-readiness
Jun 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement stub readiness endpoint - implement stub liveness endpoint - prepare unit tests
AbdelStark
added
api
Related to public APIs
continuous-integration
Related to continuous integration
docker
Related to docker
enhancement
New feature or request
labels
Jun 12, 2019
...eum/jsonrpc/src/test/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpServiceTest.java
Outdated
Show resolved
Hide resolved
...um/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/health/ReadinessService.java
Outdated
Show resolved
Hide resolved
…jsonrpc/health/ReadinessService.java Co-Authored-By: Nicolas MASSART <[email protected]>
- readiness use peer network if p2p enabled - factorize code
final methode parameter
ajsutton
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions but I'd be ok with this landing pretty much as is. We know there's additional functionality to go in anyway which will likely affect the design a bit and I'm keen for you to be able to dive into the other work your team has to focus on and we can pick this up.
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/health/HealthService.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/health/HealthService.java
Outdated
Show resolved
Hide resolved
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/health/HealthService.java
Outdated
Show resolved
Hide resolved
…s-liveness-readiness
- add meaningful text in response body - use composition instead of inheritance - remove useless methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api
Related to public APIs
continuous-integration
Related to continuous integration
docker
Related to docker
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR aims to provide responding endpoints to monitor health of Pantheon node when deployed in a Kubernetes context. No real business logic has been implemented in the health check. We consider the node ready as soon as the JSON RPC server is up.
Fixed Issue(s)
#PIE-1612
#PIE-1613