Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PIE-1612] [PIE-1613] liveness and readiness probe stub endpoints #1553

Merged

Conversation

AbdelStark
Copy link
Contributor

PR description

This PR aims to provide responding endpoints to monitor health of Pantheon node when deployed in a Kubernetes context. No real business logic has been implemented in the health check. We consider the node ready as soon as the JSON RPC server is up.

  • implement stub readiness endpoint
  • implement stub liveness endpoint
  • prepare unit tests

Fixed Issue(s)

#PIE-1612
#PIE-1613

- implement stub readiness endpoint
- implement stub liveness endpoint
- prepare unit tests
@AbdelStark AbdelStark requested a review from ajsutton June 12, 2019 07:58
@AbdelStark AbdelStark added api Related to public APIs continuous-integration Related to continuous integration docker Related to docker enhancement New feature or request labels Jun 12, 2019
AbdelStark and others added 3 commits June 12, 2019 13:10
…jsonrpc/health/ReadinessService.java

Co-Authored-By: Nicolas MASSART <[email protected]>
- readiness use peer network if p2p enabled
- factorize code
final methode parameter
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions but I'd be ok with this landing pretty much as is. We know there's additional functionality to go in anyway which will likely affect the design a bit and I'm keen for you to be able to dive into the other work your team has to focus on and we can pick this up.

- add meaningful text in response body
- use composition instead of inheritance
- remove useless methods
@AbdelStark AbdelStark merged commit d8a1dc7 into PegaSysEng:master Jun 13, 2019
@AbdelStark AbdelStark deleted the feature/kubernetes-liveness-readiness branch August 23, 2019 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Related to public APIs continuous-integration Related to continuous integration docker Related to docker enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants