Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Convert MetricsConfigiguration to use a builder #1572

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Convert MetricsConfigiguration to use a builder #1572

merged 1 commit into from
Jun 18, 2019

Conversation

ajsutton
Copy link
Contributor

PR description

Use a builder pattern to create MetricsConfiguration instead of it being a mutable object.

@ajsutton ajsutton mentioned this pull request Jun 18, 2019
Closed
AbdelStark
AbdelStark approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ajsutton ajsutton merged commit 34c4887 into PegaSysEng:master Jun 18, 2019
@ajsutton ajsutton deleted the metric-builder branch June 18, 2019 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbdelStark AbdelStark AbdelStark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajsutton @AbdelStark