Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PIE-1706] Properly validate AltBN128 pairing precompile input #1600

Merged
merged 5 commits into from
Jun 25, 2019
Merged

[PIE-1706] Properly validate AltBN128 pairing precompile input #1600

merged 5 commits into from
Jun 25, 2019

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Jun 24, 2019

PR description

Check for subgroup membership when validating inputs to AltBN128 pairing precompile. See: https://eips.ethereum.org/EIPS/eip-197 .

@mbaxter mbaxter marked this pull request as ready for review June 24, 2019 22:08
@mbaxter mbaxter changed the title Check for subgroup membership [PIE-1706] Check for subgroup membership Jun 24, 2019
@mbaxter mbaxter requested a review from drinkcoffee June 24, 2019 22:10
drinkcoffee
drinkcoffee approved these changes Jun 25, 2019
View reviewed changes
Copy link

@drinkcoffee drinkcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes. The changes look good to me.

@mbaxter mbaxter changed the title [PIE-1706] Check for subgroup membership [PIE-1706] Properly validate AltBN128 pairing precompile input Jun 25, 2019
@mbaxter mbaxter merged commit 333135b into PegaSysEng:master Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drinkcoffee drinkcoffee drinkcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbaxter @drinkcoffee