This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2829] Account versioning #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial versioning code. Main hook is that setCode() in MutableAccount now requires a version (currently a long for performance reasons). Reference tests all pass (hence the WorldStateMock if block) and GenesisStateTest has an explicit version test now.
# Conflicts: # ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/MainnetProtocolSpecs.java
In the future if the versions become sparse or large we will create a "proxy" version index by putting the standardized indexes into an enum and using the enum ordinal instead.
AbdelStark
approved these changes
Jul 11, 2019
...ore/src/test/java/tech/pegasys/pantheon/ethereum/vm/operations/ExtCodeHashOperationTest.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/tech/pegasys/pantheon/ethereum/vm/operations/ExtCodeHashOperationTest.java
Outdated
Show resolved
Hide resolved
...re/src/test/java/tech/pegasys/pantheon/ethereum/worldstate/DefaultMutableWorldStateTest.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Initial versioning code. Main hook is that setCode() in MutableAccount now
requires a version (currently a long for performance reasons).
Reference tests all pass (hence the WorldStateMock if block) and
GenesisStateTest has an explicit version test now.
Fixed Issue(s)
PAN-2829