Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PIE-1741] Refactor CLI #1627

Merged
merged 1 commit into from
Jul 2, 2019
Merged

[PIE-1741] Refactor CLI #1627

merged 1 commit into from
Jul 2, 2019

Conversation

AbdelStark
Copy link
Contributor

PR description

  • refactor packages
  • remove PantheonExceptionHandler inner class and create a separate class
  • introduce subcommand package

Fixed Issue(s)

@AbdelStark
[PIE-1741] Refactor CLI
fa4caf1 
- refactor packages
- remove `PantheonExceptionHandler` inner class and create a separate class
- introduce subcommand package
@AbdelStark AbdelStark added the refactoring Related to refactoring of code label Jul 2, 2019
@AbdelStark AbdelStark requested a review from NicolasMassart July 2, 2019 09:36
NicolasMassart
NicolasMassart approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me with also visibility changes as you splitter into multiple packages.

@AbdelStark AbdelStark merged commit 94f39d1 into PegaSysEng:master Jul 2, 2019
@AbdelStark AbdelStark deleted the feature/pie-1741-refactor-cli branch July 8, 2019 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbaxter mbaxter mbaxter left review comments

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
refactoring Related to refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbdelStark @mbaxter @NicolasMassart