Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-2797] Refactor experimental CLI options #1629

Merged
merged 23 commits into from
Jul 2, 2019
Merged

[PAN-2797] Refactor experimental CLI options #1629

merged 23 commits into from
Jul 2, 2019

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Jul 2, 2019

PR description

Refactor experimental CLI options:

  • A CLIOptions interface was created in tech.pegasys.pantheon.cli.options
    • Implementing classes hold CLI annotations and logic for parsing back and forth between domain objects and CLI options
  • Tests for these collections of CLI options have been moved from PantheonCommandTest into smaller, more targeted tests
  • PicoCLI dependencies have been removed from core packages

mbaxter added 22 commits June 20, 2019 15:28
@mbaxter
Check connections more frequently during acceptance tests
4fa95f9
@mbaxter
Get CLI params from NetworkingConfiguration
f9c716c
@mbaxter
Set a default NetworkingConfiguration
097ea41
@mbaxter
Add missing mocked method
75fa3fe
@mbaxter
Rework CLI flag handling
7183850
@mbaxter
Merge branch 'master' into PAN-2797/retry-connections
44c1e27
@mbaxter
Merge branch 'master' into PAN-2797/retry-connections
8047744
@mbaxter
Merge branch 'master' into PAN-2797/retry-connections
a33009e
@mbaxter
Rework Options interface
f60e2e2
@mbaxter
Move sync CLI config to new model, update getters
f6c1343
@mbaxter
Rework CLIOptions tests
a5b0458
@mbaxter
Create EthProtocolOptions
4f543a6
@mbaxter
Add RocksDBOptions
bea4084
@mbaxter
Merge branch 'master' into PAN-2797/retry-connections
b0b51fe
@mbaxter
Clean up tests
8febbef
@mbaxter
Merge branch 'master' into PAN-2797/refactor-cli-x-options
0f0cab0
@mbaxter
Merge branch 'master' into PAN-2797/refactor-cli-x-options
4a2be75
@mbaxter
Create TransactionPoolOptions
2a382a6
@mbaxter
Fix annotations
1ef04cb
@mbaxter
Simplify tests
51c33a3
@mbaxter
Remove NetworkingOptions
f415317
@mbaxter
Merge branch 'master' into PAN-2797/refactor-cli-x-options
f7a232f
@mbaxter mbaxter marked this pull request as ready for review July 2, 2019 17:28
@mbaxter mbaxter requested a review from shemnon July 2, 2019 17:29
shemnon
shemnon approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbaxter mbaxter merged commit c23fbc8 into PegaSysEng:master Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbaxter @shemnon