Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Factorise metrics code for KeyValueStorage database #1663

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Factorise metrics code for KeyValueStorage database #1663

merged 2 commits into from
Jul 9, 2019

Conversation

AbdelStark
Copy link
Contributor

@AbdelStark AbdelStark commented Jul 9, 2019 •
edited
Loading

PR description

  • introduce RocksDBMetricsHelper
  • factorise code
  • remove metrics instanciation in RocksDbKeyValueStorage and ColumnarRocksDbKeyValueStorage

Fixed Issue(s)

@AbdelStark
Factorise metrics code for KeyValueStorage database
fbab702 
- introduce `MonitorableKeyValueStorage`
- factorise code
- remove metrics instanciation in `RocksDbKeyValueStorage` and `ColumnarRocksDbKeyValueStorage`
@AbdelStark AbdelStark requested a review from RatanRSur July 9, 2019 16:22
@AbdelStark AbdelStark added the refactoring Related to refactoring of code label Jul 9, 2019
@AbdelStark AbdelStark merged commit b01ea42 into PegaSysEng:master Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shemnon shemnon shemnon approved these changes

@RatanRSur RatanRSur Awaiting requested review from RatanRSur

Assignees
No one assigned
Labels
refactoring Related to refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdelStark @shemnon