PAN-2741: Added error msg for calling eth_sendTransaction

[lucassaldanha]

No description provided.

[MadelineMurray]

I don't think this is quite right. Your options are:

• Use eth_sendRawTransaction with Pantheon
• Use eth_sendTransaction with a supported signer (eg, EthSigner)

You can send eth_sendRawTransaction through EthSigner but there's no benefit because the transaction would already be signed.

[lucassaldanha]

Thanks Madeline! I’ll update the message. Maybe we shouldn’t mention ethsigner here. Just eth_sendRawTx. What do you think?

On Sat, 13 Jul 2019 at 07:58, MadelineMurray ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/internal/response/JsonRpcError.java <#1681 (comment)>: > @@ -27,6 +27,11 @@ INTERNAL_ERROR(-32603, "Internal error"), METHOD_NOT_ENABLED(-32604, "Method not enabled"), + // eth_sendTransaction specific error message + ETH_SEND_TX_NOT_AVAILABLE( + -32604, + "The method eth_sendTransaction is not supported. Use eth_sendRawTransaction with a supported signer, e.g. ethsigner."), I don't think this is quite right. Your options are: - Use eth_sendRawTransaction with Pantheon - Use eth_sendTransaction with a supported signer (eg, EthSigner) You can send eth_sendRawTransaction through EthSigner but there's no benefit because the transaction would already be signed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1681?email_source=notifications&email_token=AANPIKAKRPD5DEESCB4TLWDP7DO5VA5CNFSM4ICDKSD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6KWMDA#pullrequestreview-261449228>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANPIKDPWM5J2TQTXG6URTLP7DO5VANCNFSM4ICDKSDQ> .

-- Lucas Saldanha // Protocol Engineer [email protected] / *+64 027 229 9190* Auckland, New Zealand (GMT+12) Web <https://consensys.net/> | Twitter <https://twitter.com/ConsenSys> | Facebook <https://www.facebook.com/consensussystems> | Linkedin <https://www.linkedin.com/company/consensus-systems-consensys-> | Newsletter <http://consensys.us11.list-manage.com/subscribe?u=947c9b18fc27e0b00fc2ad055&id=257df01285&utm_content=buffer1ce12&utm_medium=social&utm_source=facebook.com&utm_campaign=buffer>