This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Enclave refactoring #1684
Merged
Enclave refactoring #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce `MonitorableKeyValueStorage` - factorise code - remove metrics instanciation in `RocksDbKeyValueStorage` and `ColumnarRocksDbKeyValueStorage`
- use final modifiers when appropriate to comply with Pantheon global policy - use `assertj` assertions in tests - don't use local variables when not necessary - check exception message for `upCheck` method
iikirilov
reviewed
Jul 12, 2019
| integrationTestImplementation 'junit:junit' | ||
| integrationTestImplementation 'org.assertj:assertj-core' |
There was a problem hiding this comment.
what is the reason for using assertj over junit?
There was a problem hiding this comment.
Readability of the code mainly, it looks more a human natural semantic. Easier to read for non tech people for example. Also we try to use it in the rest of the code when possible. So also for harmonization.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
assertjassertions in testsupCheckmethodFixed Issue(s)