Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Added create, delete, and find privacy group endpoints #1721

Merged

Conversation

MadelineMurray
Copy link
Contributor

Added create, delete, and find privacy group endpoints


### eea_findPrivacyGroup

Returns a list of privacy groups that contain exactly the listed members. For example, if the listed members
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns a list of privacy groups that contain only...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


**Returns**

Privacy groups that contain exactly the specified members.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Privacy groups that contain only...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only. There's seems to be missing fullstops at the end of sentences in the Parameters and Returns section. Although I'm not sure what the style is.

Copy link
Contributor

@iikirilov iikirilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - using only instead of exactly is a good suggestion

@MadelineMurray MadelineMurray merged commit 032494f into PegaSysEng:master Jul 22, 2019
@MadelineMurray MadelineMurray deleted the createDeletePrivacyGroup branch July 22, 2019 03:57
MadelineMurray added a commit to MadelineMurray/pantheon that referenced this pull request Jul 28, 2019
rain-on pushed a commit to rain-on/pantheon that referenced this pull request Jul 28, 2019
rain-on pushed a commit to rain-on/pantheon that referenced this pull request Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants