This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Added eea_getTransactionCount #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeaGetTransactionCount
…eeaGetTransactionCount
…eeaGetTransactionCount
bgravenorst
reviewed
Jul 21, 2019
|
|
||
| `data` - Account address | ||
|
|
||
| `data` - Privacy group ID |
There was a problem hiding this comment.
Is this right? Both parameters are named 'data'. I'm not familiar enough with these APIs to make any type of suggestion though.
There was a problem hiding this comment.
They're the parameter types. The JSON-RPC parameters aren't named
bgravenorst
approved these changes
Jul 21, 2019
MadelineMurray
added a commit
to MadelineMurray/pantheon
that referenced
this pull request
Jul 28, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 28, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added eea_getTransactionCount