This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2845] Added eea_getPrivateTransaction #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadelineMurray
changed the title
iikirilov
suggested changes
Jul 21, 2019
|
|
||
| **Returns** | ||
|
|
||
| Object - [Transaction object](Pantheon-API-Objects.md#transaction-object), or `null` if not a participant in the private transaction. |
There was a problem hiding this comment.
It is not a Transaction object as specified in Pantheon-API-Objects.md
I think we should specify a Private Transaction object and link it here
bgravenorst
reviewed
Jul 23, 2019
| @@ -3771,6 +3771,56 @@ None | |||
| The `EEA` API methods are not enabled by default for JSON-RPC. Use the [`--rpc-http-api`](Pantheon-CLI-Syntax.md#rpc-http-api) | |||
| or [`--rpc-ws-api`](Pantheon-CLI-Syntax.md#rpc-ws-api) options to enable the `EEA` API methods. | |||
|
|
|||
| ### eea_getPrivateTransaction | |||
|
|
|||
| Returns the private transaction if you are a participant; otherwise, null. Get the public transaction | |||
There was a problem hiding this comment.
Minor suggestion, maybe make this a new paragraph.
"To get the public transaction, use.."
bgravenorst
reviewed
Jul 23, 2019
| | **hash** | Data, 32 bytes | Hash of the transaction. | | ||
| | **input** | Data | Data to create or invoke contract. | | ||
| | **nonce** | Quantity | Number of transactions made by the sender to the privacy group before this one. | | ||
| | **to** | Data, 20 bytes | `null` if a contract creation transaction; otherwise, contract address | |
There was a problem hiding this comment.
a few missing fullstops in the table
There was a problem hiding this comment.
That's consistent with the rest of the tables. We can revisit this on the wider basis when we look at the style guide
bgravenorst
approved these changes
Jul 23, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 26, 2019
MadelineMurray
added a commit
to MadelineMurray/pantheon
that referenced
this pull request
Jul 28, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 28, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added eea_getPrivateTransaction