This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2943] Renames various eea methods to priv methods, with associated docs #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadelineMurray
suggested changes
Jul 22, 2019
lucassaldanha
approved these changes
Jul 22, 2019
|
I hope this commit addresses the required changes: 5bc6242 |
Do we want to have the PRIV group or will we enable everything with the EEA group? |
|
As discussed, EEA enables EEA methods and PRIV enables the extended Pantheon privacy |
MadelineMurray
approved these changes
Jul 24, 2019
MadelineMurray
suggested changes
Jul 24, 2019
|
My latest commit addresses the two new refactors. Unsure whether to put |
… into eea-rename-priv
josh-richardson
force-pushed
the
eea-rename-priv
branch
from
4bf0d07 to
6aa6aa7
Compare
I'd put it into a |
CjHare
suggested changes
Jul 24, 2019
...reum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcMethodsFactory.java
Outdated
Show resolved
Hide resolved
rain-on
reviewed
Jul 24, 2019
...reum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcMethodsFactory.java
Outdated
Show resolved
Hide resolved
CjHare
approved these changes
Jul 25, 2019
MadelineMurray
approved these changes
Jul 25, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 26, 2019
…ed docs (PegaSysEng#1736) * Renames various eea methods to priv methods, with associated docs * Restructures packages * Adds priv commandline switch * Refactors eea_getTransactionCount and eea_getPrivateTransaction to priv * Changes package structure and fixes TODO * Remove whitespace * Update docs with new method names
josh-richardson
added a commit
to josh-richardson/pantheon
that referenced
this pull request
Jul 30, 2019
…ed docs (PegaSysEng#1736) * Renames various eea methods to priv methods, with associated docs * Restructures packages * Adds priv commandline switch * Refactors eea_getTransactionCount and eea_getPrivateTransaction to priv * Changes package structure and fixes TODO * Remove whitespace * Update docs with new method names
MadelineMurray
pushed a commit
that referenced
this pull request
Jul 30, 2019
* [PAN-2943] Renames various eea methods to priv methods, with associated docs (#1736) * Renames various eea methods to priv methods, with associated docs * Restructures packages * Adds priv commandline switch * Refactors eea_getTransactionCount and eea_getPrivateTransaction to priv * Changes package structure and fixes TODO * Remove whitespace * Update docs with new method names * [PAN-2972] Additional integration test for contract creation with privacyGroupId (#1762) * Unit test for send raw transaction with privacy group * Integration test works a bit better now, need to abstract to a separate subclass, fix verifyForParticipants logic bug * Abstracts nodeCanDeployWithPrivacyGroupId to separate acceptance test * Tidies up integration test * Fix whitespace * Fix inspection issues * Restructure private transaction builder * Fix default privateFrom behaviour * Remove enclave public key from parameter (#1777) * [PAN-2982] Modifies PrivGetPrivateTransaction to take public tx hash (#1778) * Modifies PrivGetPrivateTransaction to take public tx hash * Fix star imports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Renames various eea methods to priv methods, as discussed on call this morning.
Fixed Issue(s)