Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

PIE-1792: Added chainId validation to PrivateTransactionValidator #1741

Merged
merged 5 commits into from
Jul 24, 2019

Conversation

lucassaldanha
Copy link
Contributor

PR description

  • Added chainId to PrivateTransactionValidator
  • Added the following checks to PrivateTransactionValidator:
    • chainId
    • siganture maleability
    • signature matching

Copy link
Contributor

@iikirilov iikirilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha merged commit beefe15 into PegaSysEng:master Jul 24, 2019
@lucassaldanha lucassaldanha deleted the PIE-1792 branch July 24, 2019 21:57
lucassaldanha added a commit to lucassaldanha/pantheon that referenced this pull request Jul 24, 2019
…gaSysEng#1741)

* PIE-1792: Added chainId validation to PrivateTransactionValidator
lucassaldanha added a commit that referenced this pull request Jul 25, 2019
* PIE-1781: Enforce nonce validation on PrivateTransactionProcessor (#1713)

* PIE-1792: Added chainId validation to PrivateTransactionValidator (#1741)

* PIE-1792: Added chainId validation to PrivateTransactionValidator
rain-on pushed a commit to rain-on/pantheon that referenced this pull request Jul 26, 2019
…gaSysEng#1741)

* PIE-1792: Added chainId validation to PrivateTransactionValidator
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants