This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Report 0 hashrate when the mining coordinator doesn't support mining #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so ethstats reporting works for Clique based networks.
EdJoJob
approved these changes
Jul 24, 2019
ajsutton
added a commit
to ajsutton/pantheon
that referenced
this pull request
Jul 25, 2019
…egaSysEng#1744) Fixes compatibility with ethstats.net reporting for PoA networks (specifically Görli).
This was referenced Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Ethstats reporting was still failing on Clique based networks because our
eth_hashratecall returned an error when theMiningCoordinatordoesn't support hash rates. The standard behaviour is to return 0 in this case, so adjust Pantheon to match.