This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Revert "[PAN-2950] Use Clock instead of System.currentTimeMillis()" #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…illis()" This reverts commit 814b36e The needed chantes to get rid of Instant.now (which is also needed to get rid of the wall clock dependency) are too deep and intrusive into IBFT to try and speed patch them in that some APIs require re-work, so in the interst of test stability this gets sheleved until it is all ready.
mbaxter
approved these changes
Jul 26, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jul 29, 2019
…illis()" (PegaSysEng#1768) This reverts commit 814b36e The needed chantes to get rid of Instant.now (which is also needed to get rid of the wall clock dependency) are too deep and intrusive into IBFT to try and speed patch them in that some APIs require re-work, so in the interst of test stability this gets sheleved until it is all ready.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This reverts commit 814b36e
The needed changes to get rid of Instant.now (which is also needed to get rid
of the wall clock dependency) are too deep and intrusive into IBFT to try and
speed patch them in that some APIs require re-work, so in the interest of test
stability this gets shelved until it is all ready.
Fixed Issue(s)