This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2954] - Allow fixedDifficulty=1 to mean "all solutions" #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try and do a difficulty of 1 the UInt256 class used for comparison throws an error because 2^256 is 33 bytes. Instead use 2^256-1 which is 32.
mbaxter
approved these changes
Jul 30, 2019
| @@ -47,8 +47,10 @@ public boolean validate(final BlockHeader header, final BlockHeader parent) { | |||
| } | |||
| final BigInteger difficulty = | |||
| BytesValues.asUnsignedBigInteger(header.getDifficulty().getBytes()); | |||
| final UInt256 target = UInt256.of(ETHHASH_TARGET_UPPER_BOUND.divide(difficulty)); | |||
|
|
|||
| final UInt256 target = | |||
There was a problem hiding this comment.
What do you think about creating a new ethash package somewhere (ethereum/core/.../mainnet/ethash??) to consolidate these types of utilities?
There was a problem hiding this comment.
Sounds like a good idea, probably as part of ProgPow work. Opened as PAN-2998
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
If you try and do a difficulty of 1 the UInt256 class used for comparison throws
an error because 2^256 is 33 bytes. Instead use 2^256-1 which is 32 bytes.