This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
Updated docker docs for location of data path #1790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…managingPrivateTransactions
…managingPrivateTransactions
…heon into MadelineMurray-privacyReorg
…MadelineMurray-privacyReorg
…lineMurray/pantheon into MadelineMurray-managingPrivateTransactions
…heon into MadelineMurray-eeajsMethods
Errorific
reviewed
Jul 30, 2019
|
||
!!! important | ||
Do not mount a volume at the default data path (`/opt/pantheon`). Mounting a volume at the default | ||
data path stops the image from running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better worded as "...path will interfere with Pantheon's operation and prevent it from safely launching."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Errorific
reviewed
Jul 30, 2019
@@ -52,25 +52,32 @@ docker run -p <localportJSON-RPC>:8545 -p <localportWS>:8546 -p <localportP2P>:3 | |||
|
|||
## Starting Pantheon | |||
|
|||
!!! important | |||
Do not mount a volume at the default data path (`/opt/pantheon`). Mounting a volume at the default | |||
data path stops the image from running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Errorific
approved these changes
Jul 30, 2019
MadelineMurray
added a commit
to MadelineMurray/pantheon
that referenced
this pull request
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docker docs for location of data path