This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-3010] Enforce privateFrom to be present. #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iikirilov
force-pushed
the
iikirilov-pan-3010
branch
from
025337f to
41cb16d
Compare
iikirilov
force-pushed
the
iikirilov-pan-3010
branch
from
41cb16d to
d78edb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
In
eeaSendRawTransactionwe are currently assuming that the user can send a transaction without theprivateFromfield. The node will populate the private transaction with the default enclave key that is specified when starting up Pantheon.On the face of it, this seems ok. But because the transaction comes in signed - the signature does not take into account the
privateFromfield.When computing the
senderaddress on the node it is wrong.We decided to enforce that
privateFromis mandatory,Fixed Issue(s)
PAN-3010