This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2900] Fix FlatFileTaskCollection tests #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows has some slightly different Java NIO semantics, regarding size after writing and whether files are deleted on close (they aren not). The first issue is we shouldn't be using Integer.SIZE when we mean Integer.BYTES. The second issue is we cannot count on these work files showing up or being deleted from the file system consistently across platforms. The ordering is consistant within platforms but not across. The test was re-written to check the read and write file numbers instead.
mbaxter
reviewed
Aug 8, 2019
| @@ -72,8 +69,7 @@ public void shouldRollFilesWhenSizeExceeded() throws Exception { | |||
| removedTasks.add(queue.remove().getData()); | |||
| } | |||
|
|
|||
| // Fully read files should have been removed. | |||
| assertThat(getCurrentFiles(dataDir)).doesNotContain(firstFile); | |||
| assertThat(queue.getReadFileNumber()).isEqualTo(0); | |||
There was a problem hiding this comment.
If the first file has been read and closed, shouldn't the readFile number increment to 1??
Suggested change
| assertThat(queue.getReadFileNumber()).isEqualTo(0); | |
| assertThat(queue.getReadFileNumber()).isEqualTo(1); |
There was a problem hiding this comment.
The file number doesn't get updated until it actually reads the file. This change will break the test but I'm adding a tweak to make sure it advances.
…least one item from that file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Windows has some slightly different Java NIO semantics, regarding size
after writing and whether files are deleted on close (they are not immediately deleted).
The first issue is we shouldn't be using Integer.SIZE when we mean
Integer.BYTES. Integer.SIZE is bit count, BYTES is byte count.
The second issue is we cannot count on these work files showing up or
being deleted from the file system consistently across platforms. The
ordering is consistent within platforms but not across. The test was
re-written to check the read and write file numbers instead.