This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PIE-1810] Add read-only blockchain factory method #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
reviewed
Aug 13, 2019
| kvStore, new MainnetBlockHeaderFunctions()); | ||
| } | ||
|
|
||
| private DefaultBlockchain createMutableBlockchain( |
There was a problem hiding this comment.
Does this need to be DefaultBlockchain or can it simply be Blockchain? i.e. do the tests need methods on DefaultBlockchain or is the type needed for other calls?
There was a problem hiding this comment.
Some of the tests access protected methods, so just cast it here for simplicity.
shemnon
approved these changes
Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR creates separate factory methods for mutable / immutable versions of
DefaultBlockchain. For the read-only, immutable blockchain, we don't require a genesis block to be supplied as long as the blockchain storage is non-empty.