This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2842] Blake 2b tweaks #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust endianess on byte payload * f flag can have only 0 or 1 * Fewer successful vector tests * Tests for failure and edge cases
* added a test for not-finalized value
iikirilov
approved these changes
Aug 19, 2019
mbaxter
approved these changes
Aug 19, 2019
| @@ -27,21 +27,21 @@ | |||
| private Blake2bfMessageDigest messageDigest; | |||
|
|
|||
| // output when input is all 0 | |||
| private byte[] blake2bfAllZero = | |||
| private static final byte[] BLAKE2F_ALL_ZERO = | |||
There was a problem hiding this comment.
Where are these test cases coming from? Is there a spec we can link to? Would the tests be clearer if kept these values as hexary strings?
There was a problem hiding this comment.
These tests are not as useful as the precompiled test vectors. Those have more coverage. As far as I can tell they were calculated from the blake RFC.
| @@ -224,7 +224,7 @@ private int bytesToInt(final byte[] bytes) { | |||
| } | |||
|
|
|||
| private long bytesToLong(final byte[] bytes) { | |||
| return Pack.bigEndianToLong(bytes, 0); | |||
| return Pack.littleEndianToLong(bytes, 0); | |||
There was a problem hiding this comment.
Pretty bizarre that the payload is a mix of big endian and little endian values :\
There was a problem hiding this comment.
Agreed. But that's what some web3/solidity folks asked for in the EIP and got.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)