This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-3071] use object parameter instead of list of parameters for priv_createPrivacyGroup #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iikirilov
changed the title
iikirilov
force-pushed
the
pan-3071
branch
3 times, most recently
from
7cab03c to
e568dc1
Compare
...sts/acceptance/dsl/transaction/priv/PrivCreatePrivacyGroupTransactionWithoutDescription.java
Outdated
Show resolved
Hide resolved
...heon/tests/acceptance/dsl/transaction/priv/PrivCreatePrivacyGroupTransactionWithoutName.java
Outdated
Show resolved
Hide resolved
...sts/acceptance/dsl/transaction/priv/PrivCreatePrivacyGroupTransactionWithoutDescription.java
Show resolved
Hide resolved
iikirilov
force-pushed
the
pan-3071
branch
4 times, most recently
from
b4ac03f to
798c0b0
Compare
rain-on
reviewed
Aug 25, 2019
...asys/pantheon/ethereum/jsonrpc/internal/privacy/methods/priv/PrivCreatePrivacyGroupTest.java
Outdated
Show resolved
Hide resolved
...asys/pantheon/ethereum/jsonrpc/internal/privacy/methods/priv/PrivCreatePrivacyGroupTest.java
Outdated
Show resolved
Hide resolved
...asys/pantheon/ethereum/jsonrpc/internal/privacy/methods/priv/PrivCreatePrivacyGroupTest.java
Outdated
Show resolved
Hide resolved
...asys/pantheon/ethereum/jsonrpc/internal/privacy/methods/priv/PrivCreatePrivacyGroupTest.java
Show resolved
Hide resolved
iikirilov
force-pushed
the
pan-3071
branch
2 times, most recently
from
aa44aa0 to
27f1a55
Compare
rain-on
reviewed
Aug 28, 2019
...ests/src/test/java/tech/pegasys/pantheon/tests/web3j/privacy/PrivacyGroupAcceptanceTest.java
Show resolved
Hide resolved
...ests/src/test/java/tech/pegasys/pantheon/tests/web3j/privacy/PrivacyGroupAcceptanceTest.java
Show resolved
Hide resolved
...ests/src/test/java/tech/pegasys/pantheon/tests/web3j/privacy/PrivacyGroupAcceptanceTest.java
Show resolved
Hide resolved
rain-on
reviewed
Aug 28, 2019
.../pegasys/pantheon/ethereum/jsonrpc/internal/privacy/methods/priv/PrivCreatePrivacyGroup.java
Show resolved
Hide resolved
iikirilov
force-pushed
the
pan-3071
branch
2 times, most recently
from
b4d397a to
5b06ade
Compare
* also moves privacy jsonrpc package to higher level for better encapsulation of privacy code * spotless
Co-Authored-By: Josh Richardson <[email protected]>
rain-on
reviewed
Aug 29, 2019
...ests/src/test/java/tech/pegasys/pantheon/tests/web3j/privacy/PrivacyGroupAcceptanceTest.java
Show resolved
Hide resolved
...ests/src/test/java/tech/pegasys/pantheon/tests/web3j/privacy/PrivacyGroupAcceptanceTest.java
Show resolved
Hide resolved
...asys/pantheon/ethereum/jsonrpc/internal/privacy/methods/priv/PrivCreatePrivacyGroupTest.java
Outdated
Show resolved
Hide resolved
rain-on
approved these changes
Aug 30, 2019
pscott
pushed a commit
to pscott/pantheon
that referenced
this pull request
Sep 2, 2019
…v_createPrivacyGroup (PegaSysEng#1868)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
use CreatePrivacyGroupParameter instead of passing array of parameters to better handle optional parameters
Fixed Issue(s)
PAN-3071