This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PIE-1805] Create stub trace_replayBlockTransactions json-rpc method #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelStark
approved these changes
Aug 22, 2019
|
|
||
| final URL genesisJsonUrl = BlockTestUtil.getTestGenesisUrl(); | ||
| PROTOCOL_SCHEDULE = MainnetProtocolSchedule.create(); | ||
| ChainResources chainResources = getChainResources(); |
There was a problem hiding this comment.
(Suggestion) make chainResources final
iikirilov
pushed a commit
to iikirilov/pantheon
that referenced
this pull request
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR lays the groundwork for implementing the new JSON-RPC method
trace_replayBlockTransactions:BlockchainSetupUtilto a more accessible package in order to deduplicate blockchain setup logic