Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-2989] don't cache for localbalance #1875

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Aug 22, 2019

PR description

Undo the frame caching of balance for the SELFBALANCE operation.

We would need to keep the balance up to date for all value transfer calls, and
currently those happen at several orders of magnitude more often than
SELFBALANCE operation, so more CPU time would be spent updating a value that is
never read than could be saved by not going to the account trie.

We may revisit this later, but this is the quickest path to conformance.

Fixed Issue(s)

Undo the frame caching of balance for the SELFBALANCE operation.

We would need to keep the balance up to date for all value transfer calls, and
currently those happen at several orders of magnitude more often than
SELFBALANCE operation, so more CPU time would be spent updating a value that is
never read than could be saved by not going to the account trie.

We may revisit this later, but this is the quickest path to conformance.
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@shemnon shemnon merged commit 971fea4 into PegaSysEng:master Aug 22, 2019
iikirilov pushed a commit to iikirilov/pantheon that referenced this pull request Aug 22, 2019
Undo the frame caching of balance for the SELFBALANCE operation.

We would need to keep the balance up to date for all value transfer calls, and
currently those happen at several orders of magnitude more often than
SELFBALANCE operation, so more CPU time would be spent updating a value that is
never read than could be saved by not going to the account trie.

We may revisit this later, but this is the quickest path to conformance.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants