This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2824] Blake validation errors are hard errors #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the blake validation errors from soft errors (empty data) to hard errors (precompile failed).
AbdelStark
approved these changes
Aug 26, 2019
...main/java/tech/pegasys/pantheon/ethereum/mainnet/precompiles/BLAKE2BFPrecompileContract.java
Show resolved
Hide resolved
RatanRSur
approved these changes
Aug 26, 2019
|
Optionals are a good idea, but this code segment predates my time at pegasys so to do the smallest possible change I am following the design as implemented. Perhaps in another sprint. |
pscott
pushed a commit
to pscott/pantheon
that referenced
this pull request
Sep 2, 2019
Change the blake validation errors from soft errors (empty data) to hard errors (precompile failed).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Change the blake validation errors from soft errors (empty data) to hard errors
(precompile failed).