This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-3097] Use a BigInteger for Network ID #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interally we use a BigInteger for ChainID, but currently use an int for NetworkID. Because the default for NetworkID is the same value as ChainID there are some chains where this will be very problematic, and there is at least one other long-living chain outside the Int32 value range. This is a large changelist because the type is baked fairly deep into some of the other APIs and very much in the test code testing the type.
pscott
pushed a commit
to pscott/pantheon
that referenced
this pull request
Sep 2, 2019
Interally we use a `BigInteger` for ChainID, but currently use an `int` for NetworkID. Because the default for NetworkID is the same value as ChainID there are some chains where this will be very problematic, and there is at least one other long-living chain outside the 32 bit int value range. This is a large commit because the type is baked fairly deep into some of the other APIs and very much in the test code testing the type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Internally we use a BigInteger for ChainID, but currently use an int for
NetworkID. Because the default for NetworkID is the same value as ChainID there
are some chains where this will be very problematic, and there is at least
one other long-living chain outside the Int32 value range.
This is a large pull request because the type is baked fairly deep into some of
the other APIs and very much in the test code testing the type.