Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Fix key value storage clear so it removes all values #1894

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Fix key value storage clear so it removes all values #1894

merged 2 commits into from
Aug 30, 2019

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Aug 29, 2019

PR description

This fixes an issue in the rocks db storage where not all keys and values are deleted.

  • DeleteRange excludes the last key from the deleted range so an additional delete must be done to also delete the last key
  • Also as the rocks db iterator is initially invalid and requires a seek before validating I've changed the non-segmented storage to use the same approach as the segmented storage clear method

Fixed Issue(s)

usmansaleem
usmansaleem reviewed Aug 30, 2019
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jframe jframe merged commit dfec928 into PegaSysEng:master Aug 30, 2019
@jframe jframe deleted the clear_removes_all branch August 30, 2019 00:42
pscott pushed a commit to pscott/pantheon that referenced this pull request Sep 2, 2019
@jframe @pscott
Fix rocksDB storage so that clear removes all values (PegaSysEng#1894)
112cbc6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jframe @usmansaleem