This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Events API: Transaction dropped, sync status, and renames #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 95f019a.
RatanRSur
changed the title
AbdelStark
approved these changes
Sep 11, 2019
| @@ -49,17 +51,22 @@ public SyncState(final Blockchain blockchain, final EthPeers ethPeers) { | |||
| }); | |||
| } | |||
|
|
|||
| private void publishSyncStatus() { | |||
| @VisibleForTesting | |||
There was a problem hiding this comment.
(discussion) : why @VisibleForTesting if public ?
There was a problem hiding this comment.
I didn't know this before but @VisibleForTesting is for documentation purposes only! I used to think it actually changed the visibility for the tests in some special way. It's to communicate that if not for the tests, this method would be less visible.
pantheon/src/test/java/tech/pegasys/pantheon/services/PantheonEventsImplTest.java
Show resolved
Hide resolved
shemnon
reviewed
Sep 11, 2019
| @@ -141,6 +141,7 @@ public void shouldNotBeReadyWhenCustomMaxBlocksBehindIsInvalid() { | |||
| } | |||
|
|
|||
| private Optional<SyncStatus> createSyncStatus(final int currentBlock, final int highestBlock) { | |||
| return Optional.of(new SyncStatus(0, currentBlock, highestBlock)); | |||
| return Optional.of( | |||
| new tech.pegasys.pantheon.ethereum.core.SyncStatus(0, currentBlock, highestBlock)); | |||
There was a problem hiding this comment.
If only java had type aliases on import...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds the ability to listen to SyncStatus changes and transaction dropped events to the
PantheonEventsAPIFixed Issue(s)