This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Ban Peers via CLI #254
Merged
Ban Peers via CLI #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of working on #251 I needed to be able to ban certain nodes from my connection pool and let others connect. This is a general solution to add a --banned-nodeids CLI flag where the nodeIds of banned nodes are listed.
|
I think if peers are blacklisted from the command line they should stay blacklisted permanently, not be subject to the usual limit of 500 blacklisted peers. It would be very confusing for users to have nodes they explicitly blacklisted wind up being able to connect. |
Change the working of the internal PeerBlacklist so that a set of banned nodes is consulted and that list is not altered by the PeerBlacklist.
|
I started down the ban list is separate initially but felt it mixed the implementation too much. Now I have a separate set that is not updated by the PeerBlacklist. |
ajsutton
approved these changes
Nov 13, 2018
|
Raised Jira Issue NC-1874 for docs. |
Spotless. Apparently two spaces after a period in monospace fonts is a sin.
Don't pass null around.
shemnon
added a commit
to shemnon/pantheon
that referenced
this pull request
Nov 14, 2018
* Ban Peers via CLI As part of working on #251 I needed to be able to ban certain nodes from my connection pool and let others connect. This is a general solution to add a --banned-nodeids CLI flag where the nodeIds of banned nodes are listed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
As part of working on #251 I needed to be able to ban certain nodes from my
connection pool and let others connect. This is a general solution to add
a --banned-nodeids CLI flag where the nodeIds of banned nodes are listed.
Fixed Issue(s)