Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Delegate creation of additional JSON-RPC methods to the PantheonController #289

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Delegate creation of additional JSON-RPC methods to the PantheonController #289

merged 2 commits into from
Nov 21, 2018

Conversation

ajsutton
Copy link
Contributor

PR description

Instead of using instanceof and casting within RunnerBuilder to add consensus-mechanism specific JSON-RPC methods, delegate to the PantheonController instance where the type of consensus is already known.

@ajsutton
Delegate creation of consensus-specific JSON-RPC methods to the Panth…
0b8cda3 
…eonController instead of using instanceof and casting.
rain-on
rain-on approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@rain-on rain-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ajsutton ajsutton merged commit c5e78c3 into PegaSysEng:master Nov 21, 2018
@ajsutton ajsutton deleted the register-jsonrpc branch November 21, 2018 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rain-on rain-on rain-on approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajsutton @rain-on