This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Minor repairs to clique block scheduling #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clique was using integer arithmetic to calculate how much "wiggle" delay should be added when the proposer is "out of turn". This would mean when an odd number of validators was in use, the max delay would be 250ms less than the expected value.
rain-on
added a commit
to rain-on/pantheon
that referenced
this pull request
Nov 25, 2018
Clique was using integer arithmetic to calculate how much "wiggle" delay should be added when the proposer is "out of turn". This would mean when an odd number of validators was in use, the max delay would be 250ms less than the expected value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clique was using integer arithmetic to calculate how much "wiggle"
delay should be added when the proposer is "out of turn".
This would mean when an odd number of validators was in use, the
max delay would be 250ms less than the expected value.