Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[NC-1856] Extracted non-Docker CLI parameters to picoCLI mixin. #323

Merged
merged 6 commits into from
Dec 3, 2018

Conversation

mark-terry
Copy link
Contributor

PR description

Fixed Issue(s)

@mark-terry
Copy link
Contributor Author

Progress commit for review. Not for merging.

Copy link
Contributor

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need a change on casing consistency in the cli help.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some readability changes to do IMO but the base looks good

@ajsutton ajsutton added the enhancement New feature or request label Dec 2, 2018
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-terry mark-terry merged commit 2380ecd into PegaSysEng:master Dec 3, 2018
@mark-terry mark-terry deleted the NC-1856 branch December 3, 2018 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants