This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Renamed IBFT message classes #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
previously approved these changes
Nov 29, 2018
rain-on
force-pushed
the
rename
branch
2 times, most recently
from
d7af6f5 to
3c7733b
Compare
Errorific
reviewed
Nov 30, 2018
| @@ -44,8 +44,8 @@ public RoundChangeCertificate getRoundChangeCertificate() { | |||
| return roundChangeCertificate; | |||
| } | |||
|
|
|||
| public SignedData<PrepreparePayload> getIbftPrePrepareMessage() { | |||
| return ibftPrePrepareMessage; | |||
| public SignedData<ProposalPayload> getIbftPreProposalMessage() { | |||
Errorific
reviewed
Nov 30, 2018
| @@ -115,13 +115,13 @@ private boolean validatePreprepareCertificateRound( | |||
| final ConsensusRoundIdentifier roundChangeTarget) { | |||
|
|
|||
| if (prepareCertRound.getSequenceNumber() != roundChangeTarget.getSequenceNumber()) { | |||
| LOG.info("Invalid RoundChange message, PreprepareCertificate is not for local chain height."); | |||
| LOG.info("Invalid RoundChange message, PreparedCertificate is not for local chain height."); | |||
There was a problem hiding this comment.
should this be ProposalCertificate rather than PreparedCertificate?
There was a problem hiding this comment.
no - it's still a PreparedCertificate I do believe (as in, the node is in the prepared state).
Errorific
reviewed
Nov 30, 2018
| verify(basicValidator, times(1)) | ||
| .addPreprepareMessage(prepareCertificate.getIbftPrePrepareMessage()); | ||
| .createAt(prepareCertificate.getProposalMessage().getPayload().getRoundIdentifier()); | ||
| verify(basicValidator, times(1)).addPreprepareMessage(prepareCertificate.getProposalMessage()); |
There was a problem hiding this comment.
is addPreprepareMessage something that should be changed?
There was a problem hiding this comment.
refactor is not your friend - it should just be addPrepareMessage.
rain-on
force-pushed
the
rename
branch
5 times, most recently
from
8a34033 to
e3d8a40
Compare
Errorific
reviewed
Dec 6, 2018
| public SignedData<ProposalPayload> createSignedProposalPayload( | ||
| final ConsensusRoundIdentifier roundIdentifier, final Block block) { | ||
|
|
||
| ProposalPayload prePrepareUnsignedMessageData = new ProposalPayload(roundIdentifier, block); |
There was a problem hiding this comment.
prePrepareUnsignedMessageData
Errorific
approved these changes
Dec 6, 2018
jframe
approved these changes
Dec 6, 2018
| final IbftSignedMessageData<IbftUnsignedPrePrepareMessageData> preprepareMessage = | ||
| certificate.getIbftPrePrepareMessage(); | ||
| final PreparedCertificate certificate, final ConsensusRoundIdentifier roundChangeTarget) { | ||
| final SignedData<ProposalPayload> preprepareMessage = certificate.getProposalPayload(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.