This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Repair CLique Proposer Selection #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clique Proposer Selection would choose an incorrect peer when a signer was removed from the pool, as the algorithm worked purely on the block count. The algorithm has now been updated to ensure the next proposer is incrementally the next signer in the ordered list, based on the parent's proposer
Errorific
approved these changes
Nov 30, 2018
jframe
approved these changes
Nov 30, 2018
|
This broke Görli, hard. I think it should be rolled back until it doesn't break Görli |
shemnon
added a commit
to shemnon/pantheon
that referenced
this pull request
Nov 30, 2018
…li testnet Reverts PegaSysEng#339 Görli's testnet regularly has proposers miss their turn and their genesis block actually had a bad validator specified (that was voted out as soon as they could) So many blocks do not have the proper "proposer" as their block generator. As a consequence the CliqueDifficultyValidationRule fails regularly, in fact it fails at block 3, so this should be easy to re-create locally.
shemnon
added a commit
to shemnon/pantheon
that referenced
this pull request
Nov 30, 2018
…li testnet Reverts PegaSysEng#339 Görli's testnet regularly has proposers miss their turn and their genesis block actually had a bad validator specified (that was voted out as soon as they could) So many blocks do not have the proper "proposer" as their block generator. As a consequence the CliqueDifficultyValidationRule fails regularly, in fact it fails at block 3, so this should be easy to re-create locally.
shemnon
added a commit
that referenced
this pull request
Nov 30, 2018
…#343) Reverts #339 Görli's testnet regularly has proposers miss their turn and their genesis block actually had a bad validator specified (that was voted out as soon as they could) So many blocks do not have the proper "proposer" as their block generator. As a consequence the CliqueDifficultyValidationRule fails regularly, in fact it fails at block 3, so this should be easy to re-create locally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clique Proposer Selection would choose an incorrect peer
when a signer was removed from the pool, as the algorithm worked
purely on the block count.
The algorithm has now been updated to ensure the next proposer is
incrementally the next signer in the ordered list, based on the
parent's proposer