Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Update errorprone #401

Merged
merged 6 commits into from
Dec 12, 2018
Merged

Update errorprone #401

merged 6 commits into from
Dec 12, 2018

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Dec 11, 2018

  • Update errorprone from 2.3.1 to 2.3.2
  • Update Jenkinsfile so that CI will use Java 11
  • Suppress these new rules:
    • EqualsGetClass
    • ImmutableEnumChecker
    • UnnecessaryParentheses
  • Change code to conform to these new rules:
    • BadImport
    • BadInstanceof
    • InconsistentHashCode
    • LockNotBeforeTry
    • MathAbsoluteRandom
    • ModifiedButNotUsed
    • UndefinedEquals

@shemnon
Upgrade errorprone
a7fb158 
* Upgrade errorprone from 2.3.1 to 2.3.2
* Upgrade Jenkinsfile so that CI will use Java 11
* Suppress these new rules:
  * EqualsGetClass
  * ImmutableEnumChecker
  * UnnecessaryParentheses
* Change code to conform to these new rules:
  * BadImport
  * BadInstanceof
  * InconsistentHashCode
  * LockNotBeforeTry
  * MathAbsoluteRandom
  * ModifiedButNotUsed
  * UndefinedEquals
lucassaldanha
lucassaldanha approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I've added two comments re two snippets of code that are commented and I'm not sure if it was a mistake.

@shemnon shemnon merged commit c13b91f into PegaSysEng:master Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @lucassaldanha