This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Allow IBFT Round to be created using PreparedCert #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the local node is to be the proposer for a new round (due to round change), the new Ibft Round is to be created using the latest received PreparedCertificate, and a NewRound message multicast to all validators. It should be noted, the block in the NewRound Proposal must be modified from that received in the PreparedCertificate such that it contains the executing round number.
added 2 commits
December 17, 2018 13:34
Errorific
approved these changes
Dec 17, 2018
jframe
reviewed
Dec 17, 2018
| final RoundChangePayload payload = roundChangeMsg.getPayload(); | ||
| if (payload.getPreparedCertificate().isPresent()) { | ||
| if (!result.isPresent()) { | ||
| result = Optional.of(payload.getPreparedCertificate().get()); |
There was a problem hiding this comment.
this could be just result = payload.getPreparedCertificate()
| @@ -51,4 +55,28 @@ public static Block createSealedBlock( | |||
|
|
|||
| return new Block(sealedHeader, block.getBody()); | |||
| } | |||
|
|
|||
| public static Optional<PreparedCertificate> findLatestPreparedCertificate( | |||
There was a problem hiding this comment.
doesn't look there is a test for this
There was a problem hiding this comment.
Was previously fully tested as part of NewRoundMessageValidator (but was then moved out here) - have created additional tests based of the previously existing tests.
jframe
approved these changes
Dec 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the local node is to be the proposer for a new round
(due to round change), the new Ibft Round is to be created using the
latest received PreparedCertificate, and a NewRound message multicast
to all validators.
It should be noted, the block in the NewRound Proposal must be
modified from that received in the PreparedCertificate such that it
contains the executing round number (all other fields remain unchanged).