This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Initial implementation of ibft_getValidatorsByBlockNumber #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rojotek
changed the title
rain-on
reviewed
Jan 3, 2019
...ft/src/main/java/tech/pegasys/pantheon/consensus/ibft/jsonrpc/IbftJsonRpcMethodsFactory.java
Show resolved
Hide resolved
...ava/tech/pegasys/pantheon/consensus/ibft/jsonrpc/methods/IbftGetValidatorsByBlockNumber.java
Show resolved
Hide resolved
rain-on
reviewed
Jan 6, 2019
|
|
||
| @Override | ||
| protected Object resultByBlockNumber(final JsonRpcRequest request, final long blockNumber) { | ||
| Optional<BlockHeader> blockHeader = blockchainQueries().getBlockHeaderByNumber(blockNumber); |
There was a problem hiding this comment.
Suggested change
| Optional<BlockHeader> blockHeader = blockchainQueries().getBlockHeaderByNumber(blockNumber); | |
| final Optional<BlockHeader> blockHeader = blockchainQueries().getBlockHeaderByNumber(blockNumber); |
...ava/tech/pegasys/pantheon/consensus/ibft/jsonrpc/methods/IbftGetValidatorsByBlockNumber.java
Outdated
Show resolved
Hide resolved
rojotek
force-pushed
the
ibft_getValidatorsByBlockHash
branch
from
4428820 to
6aa338d
Compare
rain-on
approved these changes
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the ibft_getValidatorsByBlockNumber method. (really it is byBlockNumber not hash -- I implemented the BlockNumber version not the blockhash bersion :))