Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Fixing default resource locations inside docker #529

Merged
merged 4 commits into from
Jan 8, 2019
Merged

Fixing default resource locations inside docker #529

merged 4 commits into from
Jan 8, 2019

Conversation

Errorific
Copy link
Contributor

PR description

In docker we're expecting our default resource locations to be different than when running as a raw binary.

@Errorific Errorific requested a review from mark-terry January 8, 2019 06:07
NicolasMassart
NicolasMassart reviewed Jan 8, 2019
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have tests that the values are the right ones in the docker context and non-docker context ?

mark-terry
mark-terry reviewed Jan 8, 2019
View reviewed changes
Copy link
Contributor

@mark-terry mark-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - agree with Nicolas that some tests would be nice. 👍

@Errorific Errorific merged commit c528ecf into PegaSysEng:master Jan 8, 2019
@Errorific Errorific deleted the feature/fix_docker_default_locations branch January 8, 2019 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart left review comments

@mark-terry mark-terry mark-terry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Errorific @NicolasMassart @mark-terry