This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
RocksDB Metrics #531
Merged
RocksDB Metrics #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Measure read/get, write/put, remove, and commit latencies * Measure rollback count (latency seemed a bit much)
ajsutton
approved these changes
Jan 8, 2019
| MetricCategory.ROCKSDB, "write_latency_seconds", "Latency for write to RocksDB."); | ||
| commitLatency = | ||
| metricsSystem.createTimer( | ||
| MetricCategory.ROCKSDB, "commit_latency_seconds", "Latency for write to RocksDB."); |
There was a problem hiding this comment.
Description is incorrect, should be "for commit" not "for write"
|
|
||
| rollbackCount = | ||
| metricsSystem.createCounter( | ||
| MetricCategory.ROCKSDB, "rollback_count", "Number of transactions rolled back."); |
There was a problem hiding this comment.
Can we make the description "Number of RocksDB transactions rolled back."? I know it will have rocksdb in the key as well but it would be easy to confuse this with number of EVM transactions rolled back.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description