This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Ibft validates block on proposal reception #565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Jan 16, 2019
| @@ -47,6 +48,9 @@ public IbftRound createNewRound(final BlockHeader parentHeader, final int round) | |||
| final ConsensusRoundIdentifier roundIdentifier = | |||
| new ConsensusRoundIdentifier(nextBlockHeight, round); | |||
|
|
|||
| BlockValidator<IbftContext> blockValidator = | |||
| proposedBlock.getHeader(), parentHeader, protocolContext, FULL)) { | ||
| LOG.info("Invalid Proposal message, block did not pass header validation."); | ||
|
|
||
| final Optional<BlockValidationOutputs> validationResult = |
There was a problem hiding this comment.
I feel like validationResult is a misleading name for this - I'd expect it to either be empty to indicate valid or have an enum to give the reason it was invalid. This is maybe more blockProcessingOutputs? The BlockValidationOutputs class might be better as BlockProcessingOutputs as well. Not sure there's an ideal name in any case.
|
Too large, so has been broken into sub PRs. |
|
Closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, only the header was validated on block reception - now the block will be fully processed/validated (other than the commit seals, which will not exist until later in the process).
This has necessitated splitting up the BlockImporter into an Importer and a validator - both of which are available from the protocolSpecification.
Finally - an error existed in Ibft whereby the blockheadervalidator was specified at application startup, rather than being derived from the current block number (i.e. from ProtocolSchedule) - this has now been resolved.