This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Allow Attached rules to be flagged 'light' #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Jan 16, 2019
| rule -> { | ||
| final boolean result = rule.validate(header, parent, protocolContext); | ||
| return result; | ||
| }); |
There was a problem hiding this comment.
The result variable appears to be redundant here.
There was a problem hiding this comment.
done - returned to original
| */ | ||
| package tech.pegasys.pantheon.ethereum.mainnet; | ||
|
|
||
| public interface BlockHeaderValidationRule { |
There was a problem hiding this comment.
I don't think I'd bother introducing this extra interface. Just add includeInLightValidation to AttachedBlockHeaderValidationRule. It's somewhat confusing that a BlockHeaderValidationRule doesn't actually give you any way to validate a block header.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, only a Detached rule can be deemed "light". Going forwards with IBFT, being able to create "light" validation rules will support validating a proposed block on reception, while then importing said block with a full feature set of the same rules.