This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Ibft split extradata validation rule into components #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to validate a block separate to its commit seals, the commit seals must be validated separately to the validator content of the block. At this stage, the commit rule is _not_ light, however this change is to be conducted in subsequent PRs.
jframe
approved these changes
Jan 16, 2019
|
|
||
| final List<Address> committers = | ||
| IbftBlockHashing.recoverCommitterAddresses(header, ibftExtraData); | ||
| if (!validateCommitters(committers, validatorProvider.getValidators())) { |
There was a problem hiding this comment.
nit: this can be simplified to return validateCommitters(committers, validatorProvider.getValidators());
iikirilov
pushed a commit
to vinistevam/pantheon
that referenced
this pull request
Jan 24, 2019
In order to validate a block separate to its commit seals, the commit seals must be validated separately to the validator content of the block. At this stage, the commit rule is _not_ light, however this change is to be conducted in subsequent PRs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to validate a block separate to its commit seals, the commit
seals must be validated separately to the validator content of the
block.
At this stage, the commit rule is not light, however this change
is to be conducted in subsequent PRs.