This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Updated to remove unneeded step to start and stop Pantheon #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donntrenton
approved these changes
Jan 17, 2019
| @@ -21,8 +21,8 @@ To create a private network: | |||
|
|
|||
| 1. [Create Folders](#1-create-folders) | |||
| 1. [Create Genesis File](#2-create-genesis-file) | |||
| 1. [Start First Node and Get Node Public Key](#3-start-first-node-and-get-node-public-key) | |||
| 1. [Restart First Node as Bootnode](#4-restart-first-node-as-bootnode) | |||
| 1. [Get Node Public Key of First Node](#3-start-first-node-and-get-node-public-key) | |||
There was a problem hiding this comment.
Could this step say "Get Public Key of First Node"?
There was a problem hiding this comment.
Indeed yes, it doesn't start the node, only exports the key
Also if **3. Start First Node and Get Node Public Key ** is renamed to 3. Get Node Public Key of First Node, the link will change too, so need to be #3-get-node-public-key-of-first-node
| @@ -80,34 +80,13 @@ Copy the following genesis definition to a file called `privateNetworkGenesis.js | |||
| Do not use the accounts in the genesis file above on mainnet or any public network except for testing. | |||
| The private keys are displayed so the accounts are not secure. | |||
|
|
|||
| ### 3. Start First Node and Get Node Public Key | |||
| ### 3. Get Node Public Key of First Node | |||
There was a problem hiding this comment.
(Same comment as above)
NicolasMassart
suggested changes
Jan 18, 2019
| @@ -21,8 +21,8 @@ To create a private network: | |||
|
|
|||
| 1. [Create Folders](#1-create-folders) | |||
| 1. [Create Genesis File](#2-create-genesis-file) | |||
| 1. [Start First Node and Get Node Public Key](#3-start-first-node-and-get-node-public-key) | |||
| 1. [Restart First Node as Bootnode](#4-restart-first-node-as-bootnode) | |||
| 1. [Get Node Public Key of First Node](#3-start-first-node-and-get-node-public-key) | |||
There was a problem hiding this comment.
Indeed yes, it doesn't start the node, only exports the key
Also if **3. Start First Node and Get Node Public Key ** is renamed to 3. Get Node Public Key of First Node, the link will change too, so need to be #3-get-node-public-key-of-first-node
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue(s)
fixes #525