-
Notifications
You must be signed in to change notification settings - Fork 130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -21,15 +21,15 @@ | |||
|
|||
boolean isIbft(); | |||
|
|||
boolean isRevisedIbft(); | |||
boolean isIbft2(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't love that this is only 1 character different from isIbft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to do about that. The name is ibft 2. Thought perhaps could make the old version ibftLegacy in the method names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. renamed old ibft methods to ibftLegacy to distinguish from ibft2
|
||
boolean isClique(); | ||
|
||
IbftConfigOptions getIbftConfigOptions(); | ||
|
||
CliqueConfigOptions getCliqueConfigOptions(); | ||
|
||
IbftConfigOptions getRevisedIbftConfigOptions(); | ||
IbftConfigOptions getIbft2ConfigOptions(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. as above
@@ -21,7 +21,7 @@ | |||
|
|||
private static final String ETHASH_CONFIG_KEY = "ethash"; | |||
private static final String IBFT_CONFIG_KEY = "ibft"; | |||
private static final String REVISED_IBFT_CONFIG_KEY = "revisedibft"; | |||
private static final String REVISED_IBFT_CONFIG_KEY = "ibft2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should change the constant name (replace "Revised" with something else)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep the constant should renamed as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
PR description
Rename IBFT 2.0 config section from revisedibft to ibft2.
Fixed Issue(s)