This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
IPV6 bootnodes don't work #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IPV6 URL syntax for IPv6 addresses has the addresses enclosed in brackets. Without the brackets the address could consume the port number.
|
Is there a test we can add to ensure we don't break IPv6 syntax in the future? Might be able to do it in the |
|
The converter tests can pick apart what we need. The URI wasn't being parsed out w/o the brackets, so I made sure we checked the URI parts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The IPV6 URL syntax for IPv6 addresses has the addresses enclosed in brackets.
Without the brackets the address could consume the port number.