This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Update IbftBlockHeigntManager to accept new message types. #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2019 20:19
As future IBFT message will require only subsets of the data to be signed, the message structures need to be modified such taht the signed-data aspects can be a component of the message (Rather than the whole message). THis chnage starts this process by having a "flat" message which allows clients to query the required round, and author of the message.
CjHare
reviewed
Feb 1, 2019
| import tech.pegasys.pantheon.ethereum.core.BlockHeader; | ||
|
|
||
| public interface BlockHeightManager { | ||
|
|
||
| void start(); | ||
|
|
||
| void handleBlockTimerExpiry(ConsensusRoundIdentifier roundIdentifier); | ||
| void handleBlockTimerExpiry(final ConsensusRoundIdentifier roundIdentifier); |
There was a problem hiding this comment.
There's no point in final modifiers on interface methods, as they do nothing (the implementation has no obligation to use final).
Consistency; across the codebase interfaces don't have final for method parameters
CjHare
reviewed
Feb 1, 2019
jframe
approved these changes
Feb 1, 2019
CjHare
approved these changes
Feb 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.